装 kicad 8.0.9 (apt PPA) 后跑 kicad-cli sch erc 校验我们 emit 的
.kicad_sch 文件,发现 9/9 sheets 一开始全部报 "Failed to load schematic
file" — 父节点解析就挂掉。Bisect 找到两个语法 bug:
1. **(pin_numbers (hide no)) 不被 KiCad 8 接受**
KiCad 8 lib_symbols 里 `pin_numbers` 是 token-form,不接受 (hide
yes/no) 子块。要么省略整个 block 默认 visible,要么 `(pin_numbers
hide)` 表示隐藏。原来的 `(hide no)` 风格是 KiCad 7 旧语法。
Fix: tools/epro2/kicad/sym_writer.py 删掉 (pin_numbers (hide no))
行;KiCad 默认 visible 行为正是我们想要的。
2. **String 里的字面 \n / \r / \t 让 KiCad 解析器中止**
ESP-VoCat 的 Overview sheet 有 TEXT "Battary\n3.7V 700mAH"(多行
电池标签),EPRO2 里以**字面 0x0a 字符**存储。我们把它原样 emit
成 "..." 包住的字符串 → KiCad reader 在 quoted string 内遇到 \n
就报 parse error 不给 message。
Fix: tools/epro2/kicad/sexpr.py 在 str escape 路径加 \n / \r / \t
转义;reader 加 \r 解码(roundtrip 用)。
修完后:
9/9 sheets parse OK in KiCad 8.0.9
ERC 跑通,9 个 sheet 共 2793 violations,分布:
1372 endpoint_off_grid (49%, cosmetic — 30-mil EPRO2 grid 不
snap KiCad 默认 50-mil grid)
571 lib_symbol_issues (20%, cosmetic — facere 库未注册到
user library table;库已 embed 在
.kicad_sch 内联可用)
444 wire_dangling (16%, real — wire 端点没精确对齐 pin)
406 pin_not_connected (15%, 同上的另一面)
Cosmetic 占 70%,real connectivity 30%,下个 phase 处理:
- grid 校准(把 coord 精确 round 到统一 grid 上)
- pin tip 端点匹配(KiCad 需要 wire 端点 == pin (at) 字段对应的
绝对坐标,浮点必须精确相等)
- 生成 sym-lib-table 注册 facere 库(消 lib_symbol_issues)
测试:
+ test_string_escapes_newlines_and_tabs
+ test_lib_symbol_omits_pin_numbers_block
reader 加 \r 解码
41/41 通过(39 旧 + 2 新)。
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
182 lines
6.6 KiB
Python
182 lines
6.6 KiB
Python
"""Convert one EPRO2 SYMBOL Document → a KiCad ``(symbol ...)`` lib entry.
|
|
|
|
Phase-2 scope: render the SYMBOL primitives so KiCad's lib_symbols block can
|
|
provide a real graphical body for each placement (vs the Phase-1 red ``?``).
|
|
|
|
Coverage / fidelity:
|
|
- PART → outer (symbol "facere:<partId>" ...) wrapper + properties
|
|
- PIN + ATTR → (pin <type> line (at x y rot) (length L) (name ...) (number ...))
|
|
with ATTR(parent=pin, key="Pin Name"/"Pin Number"/"Pin Type")
|
|
pulled from sibling ATTR ops
|
|
- RECT → (rectangle (start ...) (end ...) ...)
|
|
- POLY → (polyline (pts (xy ...) ...) ...) with closed→fill
|
|
- CIRCLE → (circle (center ...) (radius ...) ...)
|
|
- TEXT → (text "..." (at ...) ...)
|
|
- ATTR (no parent / on PART) → contributes to symbol-level Reference/Value/...
|
|
(best-effort; mostly ignored at body level)
|
|
|
|
Coordinate convention:
|
|
EPRO2 SYMBOL primitives use **mil** (same as schematic); we convert via
|
|
``MIL_TO_MM = 0.0254``. KiCad lib symbol coords are **Y-up** internally,
|
|
but the placement of pins relative to body origin is what matters; for
|
|
ESP-VoCat the empirical Y orientation is consistent (pins on left at -X,
|
|
pins on right at +X), so we do not flip Y. If KiCad renders flipped, the
|
|
fix is a per-axis sign in ``_pt`` here.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from ..relations import Relations
|
|
from ..replay import Document
|
|
from .sch_writer import MIL_TO_MM
|
|
from .sexpr import Sym
|
|
|
|
# EPRO2 Pin Type -> KiCad electrical type. Empirical mapping; defaults to passive.
|
|
PIN_TYPE_MAP: dict[str, str] = {
|
|
"IN": "input",
|
|
"OUT": "output",
|
|
"BIDIR": "bidirectional",
|
|
"BIDIRECTIONAL": "bidirectional",
|
|
"TRI_STATE": "tri_state",
|
|
"TRISTATE": "tri_state",
|
|
"PASSIVE": "passive",
|
|
"POWER_IN": "power_in",
|
|
"POWER_OUT": "power_out",
|
|
"OPEN_COLLECTOR": "open_collector",
|
|
"OPEN_EMITTER": "open_emitter",
|
|
"NC": "no_connect",
|
|
"NOT_CONNECTED": "no_connect",
|
|
"UNSPECIFIED": "unspecified",
|
|
}
|
|
|
|
|
|
def _pt(v) -> float:
|
|
"""Coerce a mil number to mm. None → 0.0."""
|
|
if v is None:
|
|
return 0.0
|
|
try:
|
|
return float(v) * MIL_TO_MM
|
|
except (TypeError, ValueError):
|
|
return 0.0
|
|
|
|
|
|
def _stroke(width: float = 0.254) -> list:
|
|
return [Sym("stroke"), [Sym("width"), width], [Sym("type"), Sym("default")]]
|
|
|
|
|
|
def _fill(kind: str = "none") -> list:
|
|
return [Sym("fill"), [Sym("type"), Sym(kind)]]
|
|
|
|
|
|
def _font(size: float = 1.27) -> list:
|
|
return [Sym("effects"), [Sym("font"), [Sym("size"), size, size]]]
|
|
|
|
|
|
def _hidden_font(size: float = 1.27) -> list:
|
|
return [Sym("effects"), [Sym("font"), [Sym("size"), size, size]],
|
|
[Sym("hide"), Sym("yes")]]
|
|
|
|
|
|
def _property(name: str, value: str, idx: int, *, hide: bool = False) -> list:
|
|
return [
|
|
Sym("property"), name, value,
|
|
[Sym("at"), 0, 0, 0],
|
|
_hidden_font() if hide else _font(),
|
|
]
|
|
|
|
|
|
def write_lib_symbol(doc: Document, *, lib_prefix: str = "facere") -> list | None:
|
|
"""Render a SYMBOL Document as a KiCad ``(symbol ...)`` block (S-expr list).
|
|
|
|
Returns ``None`` if the doc has no PART (malformed lib doc). The caller
|
|
embeds the returned list into a parent ``(lib_symbols ...)`` container.
|
|
"""
|
|
if doc.doc_type != "SYMBOL":
|
|
return None
|
|
|
|
rel = Relations.build(doc)
|
|
if not rel.parts:
|
|
return None
|
|
|
|
# Pick the first PART (ESP-VoCat probe shows 1 PART per SYMBOL doc).
|
|
part_id, part = next(iter(rel.parts.items()))
|
|
title = str(part.get("title") or part_id)
|
|
|
|
# Body primitives: RECT, POLY, CIRCLE, TEXT, PIN.
|
|
body: list = [Sym("symbol"), f"{part_id}_1_1"]
|
|
for oid, obj in doc.objects.items():
|
|
t = obj.get("_type")
|
|
# Filter to primitives owned by this part (ignore stray objects)
|
|
if obj.get("partId") != part_id:
|
|
continue
|
|
if t == "RECT":
|
|
x1, y1 = _pt(obj.get("dotX1")), _pt(obj.get("dotY1"))
|
|
x2, y2 = _pt(obj.get("dotX2")), _pt(obj.get("dotY2"))
|
|
body.append([
|
|
Sym("rectangle"),
|
|
[Sym("start"), x1, y1],
|
|
[Sym("end"), x2, y2],
|
|
_stroke(),
|
|
_fill(),
|
|
])
|
|
elif t == "POLY":
|
|
pts = obj.get("points") or []
|
|
xy_list = [Sym("pts")] + [
|
|
[Sym("xy"), _pt(p.get("x")), _pt(p.get("y"))] for p in pts
|
|
if isinstance(p, dict)
|
|
]
|
|
if len(xy_list) >= 3: # at least 2 points + the "pts" tag
|
|
body.append([
|
|
Sym("polyline"),
|
|
xy_list,
|
|
_stroke(),
|
|
_fill("outline" if obj.get("closed") else "none"),
|
|
])
|
|
elif t == "CIRCLE":
|
|
body.append([
|
|
Sym("circle"),
|
|
[Sym("center"), _pt(obj.get("centerX")), _pt(obj.get("centerY"))],
|
|
[Sym("radius"), _pt(obj.get("radius"))],
|
|
_stroke(),
|
|
_fill(),
|
|
])
|
|
elif t == "TEXT":
|
|
val = str(obj.get("value") or "").strip()
|
|
if not val:
|
|
continue
|
|
body.append([
|
|
Sym("text"), val,
|
|
[Sym("at"), _pt(obj.get("x")), _pt(obj.get("y")),
|
|
float(obj.get("rotation") or 0)],
|
|
_font(),
|
|
])
|
|
elif t == "PIN":
|
|
attrs = rel.attrs_dict(oid)
|
|
pin_number = str(attrs.get("Pin Number") or "")
|
|
pin_name = str(attrs.get("Pin Name") or "")
|
|
pin_type_raw = str(attrs.get("Pin Type") or "").upper()
|
|
elec = PIN_TYPE_MAP.get(pin_type_raw, "passive")
|
|
body.append([
|
|
Sym("pin"), Sym(elec), Sym("line"),
|
|
[Sym("at"), _pt(obj.get("x")), _pt(obj.get("y")),
|
|
float(obj.get("rotation") or 0)],
|
|
[Sym("length"), _pt(obj.get("length"))],
|
|
[Sym("name"), pin_name or "~", _font()],
|
|
[Sym("number"), pin_number or "~", _font()],
|
|
])
|
|
|
|
# KiCad 8 syntax: omit `(pin_numbers ...)` block entirely to mean "visible"
|
|
# (using `(pin_numbers (hide no))` is rejected as a parse error). To hide
|
|
# we'd emit the bare token `(pin_numbers hide)`.
|
|
return [
|
|
Sym("symbol"), f"{lib_prefix}:{part_id}",
|
|
[Sym("pin_names"), [Sym("offset"), 1.016]],
|
|
[Sym("in_bom"), Sym("yes")],
|
|
[Sym("on_board"), Sym("yes")],
|
|
_property("Reference", "U", 0),
|
|
_property("Value", title, 1),
|
|
_property("Footprint", "", 2, hide=True),
|
|
_property("Datasheet", "", 3, hide=True),
|
|
body,
|
|
]
|